Skip to content

test(cache): real-vite integration fixtures + playground#408

Closed
branchseer wants to merge 1 commit into
feat/runner-cache-integrationfrom
feat/runner-vite-e2e
Closed

test(cache): real-vite integration fixtures + playground#408
branchseer wants to merge 1 commit into
feat/runner-cache-integrationfrom
feat/runner-vite-e2e

Conversation

@branchseer
Copy link
Copy Markdown
Member

Adds the real-vite e2e coverage: vite_build_cache exercises
runner-aware cache behaviour through vite build against the
companion vite PR (NODE_ENV-change invalidation, envPrefix-driven
tracked-env set, dist/ write restoration on cache hit), and
vite_dev_disable_cache verifies disableCache() short-circuits
the dev server's run from the cache.

Wires the rest of the consumer-side bits needed for vite (consumed
via the github: spec for vite-task-client) to install cleanly:

  • Pins root packageManager to pnpm@10.33.4 matching the vite
    PR's pnpm, removing a per-install version switch that produced
    an outer-vs-inner lockfile-settings mismatch when vite consumed
    vite-task as a git dep.
  • Drops the root prepare: husky so pnpm's git-dep flow doesn't
    invoke pnpm pack, which had been producing a lockfile
    resolution entry without the path: field — pnpm then
    extracted the entire vite-task monorepo into
    node_modules/@voidzero-dev/vite-task-client/ instead of the
    subpath.
  • Pins the vite catalog entry to a commit-specific pkg.pr.new
    URL so future bumps require updating this line.
  • Sets blockExoticSubdeps: false so pnpm 11 doesn't reject the
    transitive github: spec.

Refreshes the playground to use the published vite + the runner-
aware tools.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Copy link
Copy Markdown
Member Author

branchseer commented May 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c32f92dba9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-workspace.yaml
# Track the vite PR #22453 build until @voidzero-dev/vite-task-client is
# published to npm and the integration ships in a real vite release. Pinned
# to a commit-specific pkg.pr.new URL so bumps require updating this line.
vite: https://pkg.pr.new/vite@23ded7bb458062c028d7a52019133c9cfd51b105
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add Vite to the test toolchain dependencies

This adds a catalog entry for Vite, but catalog entries do not install packages by themselves. The e2e harness resolves these new ignored fixtures by putting packages/tools/node_modules/.bin on PATH and symlinking packages/tools/node_modules/vite; since packages/tools/package.json still does not depend on vite, a clean pnpm install will not create that binary and vt run --cache build in this fixture fails before exercising the cache behavior. Please add vite: "catalog:" to the installed toolchain package (and update the lockfile) or otherwise make the fixture install it.

Useful? React with 👍 / 👎.

@branchseer branchseer force-pushed the feat/runner-vite-e2e branch from c32f92d to aefe784 Compare May 28, 2026 08:02
@branchseer branchseer force-pushed the feat/runner-cache-integration branch 2 times, most recently from 1ba9f54 to d2b5429 Compare May 28, 2026 08:05
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch 2 times, most recently from 3516a20 to 26d0762 Compare May 28, 2026 08:09
@branchseer branchseer force-pushed the feat/runner-cache-integration branch from d2b5429 to 3c2c82d Compare May 28, 2026 08:09
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch from 26d0762 to 56935f9 Compare May 28, 2026 08:29
@branchseer branchseer force-pushed the feat/runner-cache-integration branch from 3c2c82d to 1d4b087 Compare May 28, 2026 08:29
@branchseer branchseer changed the title feat(runner): end-to-end vite cache integration fixtures + playground test(cache): real-vite integration fixtures + playground May 28, 2026
@branchseer branchseer force-pushed the feat/runner-cache-integration branch from 1d4b087 to fa9255d Compare May 28, 2026 09:07
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch 2 times, most recently from 7a80c90 to a1025cd Compare May 28, 2026 09:09
@branchseer branchseer force-pushed the feat/runner-cache-integration branch 2 times, most recently from 2858cb8 to a587ced Compare May 28, 2026 09:11
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch 2 times, most recently from 12641eb to e8f68dd Compare May 28, 2026 09:57
@branchseer branchseer force-pushed the feat/runner-cache-integration branch 2 times, most recently from 8c46da5 to a5cc208 Compare May 28, 2026 10:13
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch 2 times, most recently from 40d9dc4 to d5d2cb5 Compare May 28, 2026 10:43
@branchseer branchseer force-pushed the feat/runner-cache-integration branch from a5cc208 to 4a3e31d Compare May 28, 2026 10:43
Adds the real-vite e2e coverage: `vite_build_cache` exercises
runner-aware cache behaviour through `vite build` against the
companion vite PR (NODE_ENV-change invalidation, `envPrefix`-driven
tracked-env set, `dist/` write restoration on cache hit), and
`vite_dev_disable_cache` verifies `disableCache()` short-circuits
the dev server's run from the cache.

Wires the rest of the consumer-side bits needed for vite (consumed
via the `github:` spec for vite-task-client) to install cleanly:

- Adds `vite: catalog:` to `packages/tools/package.json` so
  `pnpm install` materialises `packages/tools/node_modules/.bin/vite`
  for the harness's `link_tools_packages(stage, ["vite"])` symlink
  setup.
- Pins root `packageManager` to `pnpm@10.33.4` matching the vite
  PR's pnpm, removing a per-install version switch that produced
  an outer-vs-inner lockfile-settings mismatch when vite consumed
  vite-task as a git dep.
- Drops the root `prepare: husky` so pnpm's git-dep flow doesn't
  invoke `pnpm pack`, which had been producing a lockfile
  `resolution` entry without the `path:` field — pnpm then
  extracted the *entire* vite-task monorepo into
  `node_modules/@voidzero-dev/vite-task-client/` instead of the
  subpath.
- Pins the vite catalog entry to a commit-specific `pkg.pr.new`
  URL so future bumps require updating this line.
- Sets `blockExoticSubdeps: false` so pnpm 11 doesn't reject the
  transitive `github:` spec.

Refreshes the playground to use the published vite + the runner-
aware tools.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@branchseer branchseer force-pushed the feat/runner-vite-e2e branch from d5d2cb5 to e051931 Compare May 28, 2026 11:46
@branchseer branchseer force-pushed the feat/runner-cache-integration branch from 4a3e31d to 9db3dd2 Compare May 28, 2026 11:46
@branchseer
Copy link
Copy Markdown
Member Author

Superseded by restructured 2-PR stack:

@branchseer branchseer closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant